undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

poll() exits too early with EFAULT if 1st arg is NULL

Browse Source 
If poll() is used as a milli-second sleep, like in help.c, by passing a NULL
in the 1st and a 0 in the 2nd arg, it exits with EFAULT.

As per Paolo Bonzini, the original author, this is a bug and to be fixed
Like in this commit, which is not to exit if the 2nd arg is 0. It got fixed
In gnulib in the same manner the other day.

Signed-off-by: Joachim Schmitz <jojo@schmitz-digital.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Joachim Schmitz 2012-09-17 23:23:17 +02:00 committed by Junio C Hamano
parent 98c573a902
commit 32fde6575e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
compat/poll/poll.c
View File

@ -353,7 +353,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)
/* EFAULT is not necessary to implement, but let's do it in the /* EFAULT is not necessary to implement, but let's do it in the
simplest case. */ simplest case. */
if (!pfd) if (!pfd && nfd)
{ {
errno = EFAULT; errno = EFAULT;
return -1; return -1;