poll() exits too early with EFAULT if 1st arg is NULL
If poll() is used as a milli-second sleep, like in help.c, by passing a NULL in the 1st and a 0 in the 2nd arg, it exits with EFAULT. As per Paolo Bonzini, the original author, this is a bug and to be fixed Like in this commit, which is not to exit if the 2nd arg is 0. It got fixed In gnulib in the same manner the other day. Signed-off-by: Joachim Schmitz <jojo@schmitz-digital.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
98c573a902
commit
32fde6575e
@ -353,7 +353,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)
|
||||
|
||||
/* EFAULT is not necessary to implement, but let's do it in the
|
||||
simplest case. */
|
||||
if (!pfd)
|
||||
if (!pfd && nfd)
|
||||
{
|
||||
errno = EFAULT;
|
||||
return -1;
|
||||
|
Loading…
Reference in New Issue
Block a user