undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t/t7504-commit-msg-hook.sh: use the $( ... ) construct for command substitution

Browse Source 
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command
substitution, and is supported by POSIX.  However, all but the
simplest uses become complicated quickly.  In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.

The patch was generated by:

for _f in $(find . -name "*.sh")
do
	perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg'  "${_f}"
done

and then carefully proof-read.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Elia Pinto 2016-01-08 12:06:22 +01:00 committed by Junio C Hamano
parent db0ff2c032
commit 33c85913df
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
t/t7504-commit-msg-hook.sh
View File

@ -179,7 +179,7 @@ EOF
chmod +x "$HOOK" chmod +x "$HOOK"
commit_msg_is () { commit_msg_is () {
test "`git log --pretty=format:%s%b -1`" = "$1" test "$(git log --pretty=format:%s%b -1)" = "$1"
} }
test_expect_success 'hook edits commit message' ' test_expect_success 'hook edits commit message' '