undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t6130/t9350: prepare for stringent Win32 path validation

Browse Source 
On Windows, file names cannot contain asterisks nor newline characters.
In an upcoming commit, we will make this limitation explicit,
disallowing even the creation of commits that introduce such file names.

However, in the test scripts touched by this patch, we _know_ that those
paths won't be checked out, so we _want_ to allow such file names.

Happily, the stringent path validation will be guarded via the
`core.protectNTFS` flag, so all we need to do is to force that flag off
temporarily.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This commit is contained in:
Johannes Schindelin 2019-09-09 15:43:35 +02:00
parent 9102f958ee
commit 35edce2056
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
t/t6130-pathspec-noglob.sh
View File

@ -10,6 +10,7 @@ test_expect_success 'create commits with glob characters' '
# the name "f*" in the worktree, because it is not allowed # the name "f*" in the worktree, because it is not allowed
# on Windows (the tests below do not depend on the presence # on Windows (the tests below do not depend on the presence
# of the file in the worktree) # of the file in the worktree)
git config core.protectNTFS false &&
git update-index --add --cacheinfo 100644 "$(git rev-parse HEAD:foo)" "f*" && git update-index --add --cacheinfo 100644 "$(git rev-parse HEAD:foo)" "f*" &&
test_tick && test_tick &&
git commit -m star && git commit -m star &&

2
t/t9350-fast-export.sh
View File

@ -424,7 +424,7 @@ test_expect_success 'fast-export quotes pathnames' '
test_config -C crazy-paths core.protectNTFS false && test_config -C crazy-paths core.protectNTFS false &&
(cd crazy-paths && (cd crazy-paths &&
blob=$(echo foo | git hash-object -w --stdin) && blob=$(echo foo | git hash-object -w --stdin) &&
git update-index --add \ git -c core.protectNTFS=false update-index --add \
--cacheinfo 100644 $blob "$(printf "path with\\nnewline")" \ --cacheinfo 100644 $blob "$(printf "path with\\nnewline")" \
--cacheinfo 100644 $blob "path with \"quote\"" \ --cacheinfo 100644 $blob "path with \"quote\"" \
--cacheinfo 100644 $blob "path with \\backslash" \ --cacheinfo 100644 $blob "path with \\backslash" \