undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'ad/preload-plug-memleak' into maint

Browse Source 
The preload-index codepath made copies of pathspec to give to
multiple threads, which were left leaked.

* ad/preload-plug-memleak:
  preload-index: fix memleak
This commit is contained in:
Junio C Hamano 2022-09-13 12:21:10 -07:00
commit 37317ab40b
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
preload-index.c
View File

@ -151,6 +151,12 @@ void preload_index(struct index_state *index,
} }
stop_progress(&pd.progress); stop_progress(&pd.progress);
if (pathspec) {
/* earlier we made deep copies for each thread to work with */
for (i = 0; i < threads; i++)
clear_pathspec(&data[i].pathspec);
}
trace_performance_leave("preload index"); trace_performance_leave("preload index");
trace2_data_intmax("index", NULL, "preload/sum_lstat", t2_sum_lstat); trace2_data_intmax("index", NULL, "preload/sum_lstat", t2_sum_lstat);