undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cache-tree: replace "for" loops in update_one with "while" loops

Browse Source 
The loops in update_one can be increased in two different ways: step
by one for files and by <n> for directories. "for" loop is not
suitable for this as it always steps by one and special handling is
required for directories. Replace them with "while" loops for clarity.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Nguyễn Thái Ngọc Duy 2012-12-16 11:15:26 +07:00 committed by Junio C Hamano
parent dbc3904ebc
commit 386cc8b031
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
cache-tree.c
View File

@ -259,7 +259,8 @@ static int update_one(struct cache_tree *it,
/* /*
* Find the subtrees and update them. * Find the subtrees and update them.
*/ */
for (i = 0; i < entries; i++) { i = 0;
while (i < entries) {
struct cache_entry *ce = cache[i]; struct cache_entry *ce = cache[i];
struct cache_tree_sub *sub; struct cache_tree_sub *sub;
const char *path, *slash; const char *path, *slash;
@ -271,8 +272,10 @@ static int update_one(struct cache_tree *it,
break; /* at the end of this level */ break; /* at the end of this level */
slash = strchr(path + baselen, '/'); slash = strchr(path + baselen, '/');
if (!slash) if (!slash) {
i++;
continue; continue;
}
/* /*
* a/bbb/c (base = a/, slash = /c) * a/bbb/c (base = a/, slash = /c)
* ==> * ==>
@ -289,7 +292,7 @@ static int update_one(struct cache_tree *it,
flags); flags);
if (subcnt < 0) if (subcnt < 0)
return subcnt; return subcnt;
i += subcnt - 1; i += subcnt;
sub->used = 1; sub->used = 1;
} }
@ -300,7 +303,8 @@ static int update_one(struct cache_tree *it,
*/ */
strbuf_init(&buffer, 8192); strbuf_init(&buffer, 8192);
for (i = 0; i < entries; i++) { i = 0;
while (i < entries) {
struct cache_entry *ce = cache[i]; struct cache_entry *ce = cache[i];
struct cache_tree_sub *sub; struct cache_tree_sub *sub;
const char *path, *slash; const char *path, *slash;
@ -320,7 +324,7 @@ static int update_one(struct cache_tree *it,
if (!sub) if (!sub)
die("cache-tree.c: '%.*s' in '%s' not found", die("cache-tree.c: '%.*s' in '%s' not found",
entlen, path + baselen, path); entlen, path + baselen, path);
i += sub->cache_tree->entry_count - 1; i += sub->cache_tree->entry_count;
sha1 = sub->cache_tree->sha1; sha1 = sub->cache_tree->sha1;
mode = S_IFDIR; mode = S_IFDIR;
} }
@ -328,6 +332,7 @@ static int update_one(struct cache_tree *it,
sha1 = ce->sha1; sha1 = ce->sha1;
mode = ce->ce_mode; mode = ce->ce_mode;
entlen = pathlen - baselen; entlen = pathlen - baselen;
i++;
} }
if (mode != S_IFGITLINK && !missing_ok && !has_sha1_file(sha1)) { if (mode != S_IFGITLINK && !missing_ok && !has_sha1_file(sha1)) {
strbuf_release(&buffer); strbuf_release(&buffer);