undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'sb/submodule-move-head-error-msg'

Browse Source 
"git checkout --recurse-submodules another-branch" did not report
in which submodule it failed to update the working tree, which
resulted in an unhelpful error message.

* sb/submodule-move-head-error-msg:
  submodule.c: report the submodule that an error occurs in
This commit is contained in:
Junio C Hamano 2018-07-24 14:50:43 -07:00
commit 392b3dde51
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
submodule.c
View File

@ -1682,7 +1682,7 @@ int submodule_move_head(const char *path,
argv_array_push(&cp.args, new_head ? new_head : empty_tree_oid_hex()); argv_array_push(&cp.args, new_head ? new_head : empty_tree_oid_hex());
if (run_command(&cp)) { if (run_command(&cp)) {
ret = -1; ret = error(_("Submodule '%s' could not be updated."), path);
goto out; goto out;
} }

3
t/lib-submodule-update.sh
View File

@ -782,7 +782,8 @@ test_submodule_recursing_with_args_common() {
( (
cd submodule_update && cd submodule_update &&
git branch -t invalid_sub1 origin/invalid_sub1 && git branch -t invalid_sub1 origin/invalid_sub1 &&
test_must_fail $command invalid_sub1 && test_must_fail $command invalid_sub1 2>err &&
test_i18ngrep sub1 err &&
test_superproject_content origin/add_sub1 && test_superproject_content origin/add_sub1 &&
test_submodule_content sub1 origin/add_sub1 test_submodule_content sub1 origin/add_sub1
) )