undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

diffcore-pickaxe: simplify has_changes and contains

Browse Source 
Halve the number of callsites of contains() to two using temporary
variables, simplifying the code.  While at it, get rid of the
diff_options parameter, which became unused with 8fa4b09f.

Signed-off-by: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
René Scharfe 2013-07-06 15:53:27 +02:00 committed by Junio C Hamano
parent 61690bf4a1
commit 3bdb5b9f1f
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
diffcore-pickaxe.c
View File

@ -131,8 +131,7 @@ static void diffcore_pickaxe_grep(struct diff_options *o)
return; return;
} }
static unsigned int contains(mmfile_t *mf, struct diff_options *o, static unsigned int contains(mmfile_t *mf, regex_t *regexp, kwset_t kws)
regex_t *regexp, kwset_t kws)
{ {
unsigned int cnt; unsigned int cnt;
unsigned long sz; unsigned long sz;
@ -176,11 +175,9 @@ static int has_changes(mmfile_t *one, mmfile_t *two,
struct diff_options *o, struct diff_options *o,
regex_t *regexp, kwset_t kws) regex_t *regexp, kwset_t kws)
{ {
if (!one) unsigned int one_contains = one ? contains(one, regexp, kws) : 0;
return contains(two, o, regexp, kws) != 0; unsigned int two_contains = two ? contains(two, regexp, kws) : 0;
if (!two) return one_contains != two_contains;
return contains(one, o, regexp, kws) != 0;
return contains(one, o, regexp, kws) != contains(two, o, regexp, kws);
} }
static int pickaxe_match(struct diff_filepair *p, struct diff_options *o, static int pickaxe_match(struct diff_filepair *p, struct diff_options *o,