undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

reftable: add test for length of disambiguating prefix

Browse Source 
The ID => ref map is trimming object IDs to a disambiguating prefix.
Check that we are computing their length correctly.

Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Han-Wen Nienhuys 2022-02-21 18:46:09 +00:00 committed by Junio C Hamano
parent b4007fcc6f
commit 3c443a02a9
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
reftable/readwrite_test.c
View File

@ -703,6 +703,43 @@ static void test_write_object_id_min_length(void)
strbuf_release(&buf); strbuf_release(&buf);
} }
static void test_write_object_id_length(void)
{
struct reftable_write_options opts = {
.block_size = 75,
};
struct strbuf buf = STRBUF_INIT;
struct reftable_writer *w =
reftable_new_writer(&strbuf_add_void, &buf, &opts);
uint8_t hash[GIT_SHA1_RAWSZ] = {42};
struct reftable_ref_record ref = {
.update_index = 1,
.value_type = REFTABLE_REF_VAL1,
.value.val1 = hash,
};
int err;
int i;
reftable_writer_set_limits(w, 1, 1);
/* Write the same hash in many refs. If there is only 1 hash, the
* disambiguating prefix is length 0 */
for (i = 0; i < 256; i++) {
char name[256];
snprintf(name, sizeof(name), "ref%05d", i);
ref.refname = name;
ref.value.val1[15] = i;
err = reftable_writer_add_ref(w, &ref);
EXPECT_ERR(err);
}
err = reftable_writer_close(w);
EXPECT_ERR(err);
EXPECT(writer_stats(w)->object_id_len == 16);
reftable_writer_free(w);
strbuf_release(&buf);
}
static void test_write_empty_key(void) static void test_write_empty_key(void)
{ {
struct reftable_write_options opts = { 0 }; struct reftable_write_options opts = { 0 };
@ -808,6 +845,7 @@ int readwrite_test_main(int argc, const char *argv[])
RUN_TEST(test_write_empty_key); RUN_TEST(test_write_empty_key);
RUN_TEST(test_write_empty_table); RUN_TEST(test_write_empty_table);
RUN_TEST(test_log_overflow); RUN_TEST(test_log_overflow);
RUN_TEST(test_write_object_id_length);
RUN_TEST(test_write_object_id_min_length); RUN_TEST(test_write_object_id_min_length);
return 0; return 0;
} }