undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

http_get_file: style fixes

Browse Source 
Besides being ugly, the extra parentheses are idiomatic for
suppressing compiler warnings when we are assigning within a
conditional. We aren't doing that here, and they just
confuse the reader.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
This commit is contained in:
Jeff King 2013-09-28 04:31:00 -04:00 committed by Jonathan Nieder
parent 02a110ad43
commit 3d1fb769b2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
http.c
View File

@ -941,7 +941,7 @@ static int http_get_file(const char *url, const char *filename, int options)
strbuf_addf(&tmpfile, "%s.temp", filename); strbuf_addf(&tmpfile, "%s.temp", filename);
result = fopen(tmpfile.buf, "a"); result = fopen(tmpfile.buf, "a");
if (! result) { if (!result) {
error("Unable to open local file %s", tmpfile.buf); error("Unable to open local file %s", tmpfile.buf);
ret = HTTP_ERROR; ret = HTTP_ERROR;
goto cleanup; goto cleanup;
@ -950,7 +950,7 @@ static int http_get_file(const char *url, const char *filename, int options)
ret = http_request_reauth(url, NULL, result, HTTP_REQUEST_FILE, options); ret = http_request_reauth(url, NULL, result, HTTP_REQUEST_FILE, options);
fclose(result); fclose(result);
if ((ret == HTTP_OK) && move_temp_to_file(tmpfile.buf, filename)) if (ret == HTTP_OK && move_temp_to_file(tmpfile.buf, filename))
ret = HTTP_ERROR; ret = HTTP_ERROR;
cleanup: cleanup:
strbuf_release(&tmpfile); strbuf_release(&tmpfile);