undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add -p: do not attempt to coalesce mode changes

Browse Source 
In 0392513 (add-interactive: refactor mode hunk handling, 2009-04-16),
we merged the interaction loops for mode changes and hunk staging.
This was fine at the time, because 0beee4c (git-add--interactive:
remove hunk coalescing, 2008-07-02) removed hunk coalescing.

However, in 7a26e65 (Revert "git-add--interactive: remove hunk
coalescing", 2009-05-16), we resurrected it.  Since then, the code
would attempt in vain to merge mode changes with diff hunks,
corrupting both in the process.

We add a check to the coalescing loop to ensure it only looks at diff
hunks, thus skipping mode changes.

Noticed-by: Kirill Smelkov <kirr@mns.spb.ru>
Signed-off-by: Thomas Rast <trast@student.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Thomas Rast 2009-08-15 15:56:39 +02:00 committed by Junio C Hamano
parent 87ca2eaade
commit 3d792161b1
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
git-add--interactive.perl
View File

@ -841,6 +841,10 @@ sub coalesce_overlapping_hunks {
my ($last_o_ctx, $last_was_dirty); my ($last_o_ctx, $last_was_dirty);
for (grep { $_->{USE} } @in) { for (grep { $_->{USE} } @in) {
if ($_->{TYPE} ne 'hunk') {
push @out, $_;
next;
}
my $text = $_->{TEXT}; my $text = $_->{TEXT};
my ($o_ofs) = parse_hunk_header($text->[0]); my ($o_ofs) = parse_hunk_header($text->[0]);
if (defined $last_o_ctx && if (defined $last_o_ctx &&

2
t/t3701-add-interactive.sh
View File

@ -164,7 +164,7 @@ test_expect_success FILEMODE 'stage mode but not hunk' '
' '
test_expect_failure FILEMODE 'stage mode and hunk' ' test_expect_success FILEMODE 'stage mode and hunk' '
git reset --hard && git reset --hard &&
echo content >>file && echo content >>file &&
chmod +x file && chmod +x file &&