undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

notes: don't access hash of NULL object_id pointer

Browse Source 
Check if note is NULL, as we already do for different purposes a few
lines above, and pass a NULL pointer to prepare_note_data() in that
case instead of trying to access the hash member.

Found with Clang's UBSan.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Acked-by: Brandon Williams <bmwill@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
René Scharfe 2017-07-15 20:15:26 +02:00 committed by Junio C Hamano
parent fb04dced9c
commit 3ea6b85a87
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
builtin/notes.c
View File

@ -453,7 +453,7 @@ static int add(int argc, const char **argv, const char *prefix)
oid_to_hex(&object)); oid_to_hex(&object));
} }
prepare_note_data(&object, &d, note->hash); prepare_note_data(&object, &d, note ? note->hash : NULL);
if (d.buf.len || allow_empty) { if (d.buf.len || allow_empty) {
write_note_data(&d, new_note.hash); write_note_data(&d, new_note.hash);
if (add_note(t, &object, &new_note, combine_notes_overwrite)) if (add_note(t, &object, &new_note, combine_notes_overwrite))