t5516: remove ambiguity test (1)
This test tried to push into a remote with ambiguous refs in remotes/$x/master and remotes/$y/master. However, the remote never actually tells us about the refs/remotes hierarchy, so we don't even see this ambiguity. The test happened to pass because we were simply looking for failure, and the test fails for another reason: the dst refspec does not exist and does not begin with refs/, making it invalid. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
837f3b7658
commit
3ef6a1fe95
@ -178,19 +178,7 @@ test_expect_success 'push with weak ambiguity (2)' '
|
|||||||
|
|
||||||
'
|
'
|
||||||
|
|
||||||
test_expect_success 'push with ambiguity (1)' '
|
test_expect_success 'push with ambiguity' '
|
||||||
|
|
||||||
mk_test remotes/origin/master remotes/frotz/master &&
|
|
||||||
if git push testrepo master:master
|
|
||||||
then
|
|
||||||
echo "Oops, should have failed"
|
|
||||||
false
|
|
||||||
else
|
|
||||||
check_push_result $the_first_commit remotes/origin/master remotes/frotz/master
|
|
||||||
fi
|
|
||||||
'
|
|
||||||
|
|
||||||
test_expect_success 'push with ambiguity (2)' '
|
|
||||||
|
|
||||||
mk_test heads/frotz tags/frotz &&
|
mk_test heads/frotz tags/frotz &&
|
||||||
if git push testrepo master:frotz
|
if git push testrepo master:frotz
|
||||||
|
Loading…
Reference in New Issue
Block a user