undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t9600-cvsimport.sh: set HOME before checking for cvsps availability

Browse Source 
This actually sounds like a bug in cvsps, which requires an existing
home directory when asked for the usage through -h

 $ HOME=/nonexistent cvsps -h
 Cannot create the cvsps directory '.cvsps': No such file or directory

This made t9600 think that cvsps is not available if HOME did not exist,
causing the tests to be skipped

 $ HOME=/nonexistent sh t9600-cvsimport.sh
 * skipping cvsimport tests, cvsps not found
 * passed all 0 test(s)

Now t9600 sets HOME to the current working directory before checking for
the availability of the cvsps program.

This issue has been discovered by Marco Rodrigues, and fixed by Frank
Lichtenheld through
 http://bugs.debian.org/471969

Signed-off-by: Gerrit Pape <pape@smarden.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Frank Lichtenheld 2008-03-26 17:34:20 +00:00 committed by Junio C Hamano
parent af05d67939
commit 40ae8872a1
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
t/t9600-cvsimport.sh
View File

@ -3,6 +3,12 @@
test_description='git-cvsimport basic tests' test_description='git-cvsimport basic tests'
. ./test-lib.sh . ./test-lib.sh
CVSROOT=$(pwd)/cvsroot
export CVSROOT
# for clean cvsps cache
HOME=$(pwd)
export HOME
if ! type cvs >/dev/null 2>&1 if ! type cvs >/dev/null 2>&1
then then
say 'skipping cvsimport tests, cvs not found' say 'skipping cvsimport tests, cvs not found'
@ -26,12 +32,6 @@ case "$cvsps_version" in
;; ;;
esac esac
CVSROOT=$(pwd)/cvsroot
export CVSROOT
# for clean cvsps cache
HOME=$(pwd)
export HOME
test_expect_success 'setup cvsroot' 'cvs init' test_expect_success 'setup cvsroot' 'cvs init'
test_expect_success 'setup a cvs module' ' test_expect_success 'setup a cvs module' '