undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

submodule: rename add_sha1_to_array()

Browse Source 
Rename 'add_sha1_to_array()' to 'append_oid_to_array()' to more
accurately describe what the function does, since it handles
'struct object_id' and not sha1 character arrays.

Signed-off-by: Brandon Williams <bmwill@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Brandon Williams 2017-04-28 16:53:57 -07:00 committed by Junio C Hamano
parent 027a3b943b
commit 419fd7866c
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
submodule.c
View File

@ -951,17 +951,18 @@ static void submodule_collect_changed_cb(struct diff_queue_struct *q,
} }
} }
static int add_sha1_to_array(const char *ref, const struct object_id *oid, static int append_oid_to_array(const char *ref, const struct object_id *oid,
int flags, void *data) int flags, void *data)
{ {
oid_array_append(data, oid); struct oid_array *array = data;
oid_array_append(array, oid);
return 0; return 0;
} }
void check_for_new_submodule_commits(struct object_id *oid) void check_for_new_submodule_commits(struct object_id *oid)
{ {
if (!initialized_fetch_ref_tips) { if (!initialized_fetch_ref_tips) {
for_each_ref(add_sha1_to_array, &ref_tips_before_fetch); for_each_ref(append_oid_to_array, &ref_tips_before_fetch);
initialized_fetch_ref_tips = 1; initialized_fetch_ref_tips = 1;
} }