undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

submodule--helper: avoid memory leak when fetching submodules

Browse Source 
In c51f8f94e5b3 (submodule--helper: run update procedures from C,
2021-08-24), we added code that first obtains the default remote, and
then adds that to a `strvec`.

However, we never released the default remote's memory.

Reported by Coverity.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Johannes Schindelin 2022-06-15 23:35:41 +00:00 committed by Junio C Hamano
parent f53559227c
commit 41a86b64c0
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
builtin/submodule--helper.c
View File

@ -2208,6 +2208,7 @@ static int fetch_in_submodule(const char *module_path, int depth, int quiet, str
char *hex = oid_to_hex(oid); char *hex = oid_to_hex(oid);
char *remote = get_default_remote(); char *remote = get_default_remote();
strvec_pushl(&cp.args, remote, hex, NULL); strvec_pushl(&cp.args, remote, hex, NULL);
free(remote);
} }
return run_command(&cp); return run_command(&cp);