undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t/t4102-apply-rename.sh: avoid "test <cond> -a/-o <cond>"

Browse Source 
The construct is error-prone; "test" being built-in in most modern
shells, the reason to avoid "test <cond> && test <cond>" spawning
one extra process by using a single "test <cond> -a <cond>" no
longer exists.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Elia Pinto 2014-06-06 07:55:57 -07:00 committed by Junio C Hamano
parent 66e1fe7db6
commit 4399345d5e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
t/t4102-apply-rename.sh
View File

@ -52,6 +52,6 @@ EOF
test_expect_success 'apply copy' \ test_expect_success 'apply copy' \
'git apply --index --stat --summary --apply test-patch && 'git apply --index --stat --summary --apply test-patch &&
test "$(cat bar)" = "This is bar" -a "$(cat foo)" = "This is foo"' test "$(cat bar)" = "This is bar" && test "$(cat foo)" = "This is foo"'
test_done test_done