undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MinGW: Report errors when failing to launch the html browser.

Browse Source 
The mingw function to launch the system html browser is silent if the
target file does not exist leaving the user confused. Make it display
something.

Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
Reviewed-by: Erik Faye-Lund <kusmabite@gmail.com>
This commit is contained in:
Pat Thoyts 2010-03-18 21:45:19 +00:00
parent 9b9784cab9
commit 442dada22d
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
compat/mingw.c
View File

@ -1417,6 +1417,7 @@ void mingw_open_html(const char *unixpath)
const char *, const char *, const char *, INT); const char *, const char *, const char *, INT);
T ShellExecute; T ShellExecute;
HMODULE shell32; HMODULE shell32;
int r;
shell32 = LoadLibrary("shell32.dll"); shell32 = LoadLibrary("shell32.dll");
if (!shell32) if (!shell32)
@ -1426,9 +1427,12 @@ void mingw_open_html(const char *unixpath)
die("cannot run browser"); die("cannot run browser");
printf("Launching default browser to display HTML ...\n"); printf("Launching default browser to display HTML ...\n");
ShellExecute(NULL, "open", htmlpath, NULL, "\\", 0); r = (int)ShellExecute(NULL, "open", htmlpath, NULL, "\\", SW_SHOWNORMAL);
FreeLibrary(shell32); FreeLibrary(shell32);
/* see the MSDN documentation referring to the result codes here */
if (r <= 32) {
die("failed to launch browser for %.*s", MAX_PATH, unixpath);
}
} }
int link(const char *oldpath, const char *newpath) int link(const char *oldpath, const char *newpath)