undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent send-pack from segfaulting when a branch doesn't match

Browse Source 
If `git push url foo` can't find a local branch named foo we can't
match it to any remote branch as the local branch is NULL and its
name is probably at position 0x34 in memory.  On most systems that
isn't a valid address for git-send-pack's virtual address space
and we segfault.

If we can't find a source match and we have no destination we
need to abort the match function early before we try to match the
destination against the remote.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Shawn O. Pearce 2007-09-25 00:13:25 -04:00 committed by Junio C Hamano
parent 7dfee372b0
commit 4491e62ae9
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
remote.c
View File

@ -610,8 +610,11 @@ static int match_explicit(struct ref *src, struct ref *dst,
if (!matched_src)
errs = 1;
if (!dst_value)
if (!dst_value) {
if (!matched_src)
return errs;
dst_value = matched_src->name;
}
switch (count_refspec_match(dst_value, dst, &matched_dst)) {
case 1: