undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid segfault with 'git branch' when the HEAD is detached

Browse Source 
A recent addition to the ref_item struct was not taken care of, leading
to a segmentation fault when accessing the (uninitialized) "dest" member.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Johannes Schindelin 2009-02-18 19:14:59 +01:00 committed by Junio C Hamano
parent 209d336ae3
commit 45e2b61401
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
builtin-branch.c
View File

@ -432,7 +432,9 @@ static void print_ref_list(int kinds, int detached, int verbose, int abbrev, str
is_descendant_of(head_commit, with_commit)) { is_descendant_of(head_commit, with_commit)) {
struct ref_item item; struct ref_item item;
item.name = xstrdup("(no branch)"); item.name = xstrdup("(no branch)");
item.len = strlen(item.name);
item.kind = REF_LOCAL_BRANCH; item.kind = REF_LOCAL_BRANCH;
item.dest = NULL;
item.commit = head_commit; item.commit = head_commit;
if (strlen(item.name) > ref_list.maxwidth) if (strlen(item.name) > ref_list.maxwidth)
ref_list.maxwidth = strlen(item.name); ref_list.maxwidth = strlen(item.name);