undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

clone --mirror: avoid storing repeated tags

Browse Source 
With --mirror, clone asks for refs/* already, so it does not need to
ask for ref/tags/*, too.

Noticed by Cesar Eduardo Barros.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Johannes Schindelin 2008-08-08 04:29:35 +02:00 committed by Junio C Hamano
parent 1fdf6ee6f8
commit 468386a956
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
builtin-clone.c
View File

@ -330,6 +330,7 @@ static struct ref *write_remote_refs(const struct ref *refs,
struct ref *r; struct ref *r;
get_fetch_map(refs, refspec, &tail, 0); get_fetch_map(refs, refspec, &tail, 0);
if (!option_mirror)
get_fetch_map(refs, tag_refspec, &tail, 0); get_fetch_map(refs, tag_refspec, &tail, 0);
for (r = local_refs; r; r = r->next) for (r = local_refs; r; r = r->next)

12
t/t5601-clone.sh
View File

@ -95,4 +95,16 @@ test_expect_success 'clone --bare names the local repository <name>.git' '
' '
test_expect_success 'clone --mirror does not repeat tags' '
(cd src &&
git tag some-tag HEAD) &&
git clone --mirror src mirror2 &&
(cd mirror2 &&
git show-ref 2> clone.err > clone.out) &&
test_must_fail grep Duplicate mirror2/clone.err &&
grep some-tag mirror2/clone.out
'
test_done test_done