mktag tests: stress test whitespace handling
Add tests for a couple of whitespace edge cases around the header/body boundary. I consider the requirement for a blank line before the empty body a bug, it's a long-standing regression which goes against the command's documented behavior. This bug will be addressed in a follow-up change. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
3b9e4dd3a3
commit
47c95e77d1
@ -337,6 +337,42 @@ EOF
|
|||||||
check_verify_failure 'detect invalid header entry' \
|
check_verify_failure 'detect invalid header entry' \
|
||||||
'^error: char.*: trailing garbage in tag header$'
|
'^error: char.*: trailing garbage in tag header$'
|
||||||
|
|
||||||
|
cat >tag.sig <<EOF
|
||||||
|
object $head
|
||||||
|
type commit
|
||||||
|
tag mytag
|
||||||
|
tagger T A Gger <tagger@example.com> 1206478233 -0500
|
||||||
|
|
||||||
|
|
||||||
|
this line comes after an extra newline
|
||||||
|
EOF
|
||||||
|
|
||||||
|
test_expect_success 'allow extra newlines at start of body' '
|
||||||
|
git mktag <tag.sig
|
||||||
|
'
|
||||||
|
|
||||||
|
cat >tag.sig <<EOF
|
||||||
|
object $head
|
||||||
|
type commit
|
||||||
|
tag mytag
|
||||||
|
tagger T A Gger <tagger@example.com> 1206478233 -0500
|
||||||
|
|
||||||
|
EOF
|
||||||
|
|
||||||
|
test_expect_success 'require a blank line before an empty body (1)' '
|
||||||
|
git mktag <tag.sig
|
||||||
|
'
|
||||||
|
|
||||||
|
cat >tag.sig <<EOF
|
||||||
|
object $head
|
||||||
|
type commit
|
||||||
|
tag mytag
|
||||||
|
tagger T A Gger <tagger@example.com> 1206478233 -0500
|
||||||
|
EOF
|
||||||
|
|
||||||
|
check_verify_failure 'require a blank line before an empty body (2)' \
|
||||||
|
'^error: char.*: trailing garbage in tag header$'
|
||||||
|
|
||||||
############################################################
|
############################################################
|
||||||
# 24. create valid tag
|
# 24. create valid tag
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user