undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PATCH] gitk: properly deal with tag names containing / (slash)

Browse Source 
When creating a tag through gitk, and the tag name includes a slash (or
slashes), gitk errors out in a popup window.  This patch makes gitk use
'git tag' to create the tag instead of modifying files in refs/tags/,
which fixes the issue; if 'git tag' throws an error, gitk pops up with
the error message.

The problem was reported by Frédéric Brière through
 http://bugs.debian.org/464104

Signed-off-by: Gerrit Pape <pape@smarden.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
Gerrit Pape 2008-02-11 10:57:40 +00:00 committed by Paul Mackerras
parent b9b86007e2
commit 48750d6a84
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gitk
View File

@ -6149,11 +6149,7 @@ proc domktag {} {
return
}
if {[catch {
set dir [gitdir]
set fname [file join $dir "refs/tags" $tag]
set f [open $fname w]
puts $f $id
close $f
exec git tag $tag $id
} err]} {
error_popup "[mc "Error creating tag:"] $err"
return