undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refuse to create funny refs in clone-pack, git-fetch and receive-pack.

Browse Source 
Using git-check-ref-format, make sure we do not create refs with
funny names when cloning from elsewhere (clone-pack), fast forwarding
local heads (git-fetch), or somebody pushes into us (receive-pack).

Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Junio C Hamano 2005-10-15 17:10:14 -07:00
parent 652d5dc6c0
commit 48bc2fb0cd
3 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clone-pack.c
View File

@ -34,6 +34,12 @@ static void write_one_ref(struct ref *ref)
int fd; int fd;
char *hex; char *hex;
if (!strncmp(ref->name, "refs/", 5) &&
check_ref_format(ref->name + 5)) {
error("refusing to create funny ref '%s' locally", ref->name);
return;
}
if (safe_create_leading_directories(path)) if (safe_create_leading_directories(path))
die("unable to create leading directory for %s", ref->name); die("unable to create leading directory for %s", ref->name);
fd = open(path, O_CREAT | O_EXCL | O_WRONLY, 0666); fd = open(path, O_CREAT | O_EXCL | O_WRONLY, 0666);

6
git-parse-remote.sh
View File

@ -94,6 +94,12 @@ canon_refs_list_for_fetch () {
heads/* | tags/* ) local="refs/$local" ;; heads/* | tags/* ) local="refs/$local" ;;
*) local="refs/heads/$local" ;; *) local="refs/heads/$local" ;;
esac esac
if local_ref_name=$(expr "$local" : 'refs/\(.*\)')
then
git-check-ref-format "$local_ref_name" ||
die "* refusing to create funny ref '$local_ref_name' locally"
fi
echo "${dot_prefix}${force}${remote}:${local}" echo "${dot_prefix}${force}${remote}:${local}"
dot_prefix=. dot_prefix=.
done done

4
receive-pack.c
View File

@ -95,6 +95,10 @@ static int update(const char *name,
char new_hex[60], *old_hex, *lock_name; char new_hex[60], *old_hex, *lock_name;
int newfd, namelen, written; int newfd, namelen, written;
if (!strncmp(name, "refs/", 5) && check_ref_format(name + 5))
return error("refusing to create funny ref '%s' locally",
name);
namelen = strlen(name); namelen = strlen(name);
lock_name = xmalloc(namelen + 10); lock_name = xmalloc(namelen + 10);
memcpy(lock_name, name, namelen); memcpy(lock_name, name, namelen);