undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Free the path_lists used to find non-local tags in git-fetch

Browse Source 
To support calling find_non_local_tags() more than once in a single
git-fetch process we need the existing_refs to be stack-allocated
so it resets on the second call.  We also should free the path
lists to avoid unnecessary memory leaking.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Shawn O. Pearce 2008-03-02 21:35:10 -05:00 committed by Junio C Hamano
parent c50b2b4799
commit 49d58fd077
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
builtin-fetch.c
View File

@ -457,7 +457,7 @@ static void find_non_local_tags(struct transport *transport,
struct ref **head, struct ref **head,
struct ref ***tail) struct ref ***tail)
{ {
static struct path_list existing_refs = { NULL, 0, 0, 0 }; struct path_list existing_refs = { NULL, 0, 0, 0 };
struct path_list new_refs = { NULL, 0, 0, 1 }; struct path_list new_refs = { NULL, 0, 0, 1 };
char *ref_name; char *ref_name;
int ref_name_len; int ref_name_len;
@ -503,6 +503,8 @@ static void find_non_local_tags(struct transport *transport,
} }
free(ref_name); free(ref_name);
} }
path_list_clear(&existing_refs, 0);
path_list_clear(&new_refs, 0);
} }
static int do_fetch(struct transport *transport, static int do_fetch(struct transport *transport,