undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gitweb: Move 'lineno' id from link to row element in git_blame

Browse Source 
Move l<line number> ID from <a> link element inside table row (inside
cell element for column with line numbers), to encompassing <tr> table
row element.  It was done to make it easier to manipulate result HTML
with DOM, and to be able write 'blame_incremental' view with the same,
or nearly the same result.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Acked-by: Luben Tuikov <ltuikov@yahoo.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jakub Narebski 2008-12-09 23:46:16 +01:00 committed by Junio C Hamano
parent f371d3ea3c
commit 4a24bfc220
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gitweb/gitweb.perl
View File

@ -4645,7 +4645,7 @@ HTML
if ($group_size) { if ($group_size) {
$current_color = ++$current_color % $num_colors; $current_color = ++$current_color % $num_colors;
} }
print "<tr class=\"$rev_color[$current_color]\">\n"; print "<tr id=\"l$lineno\" class=\"$rev_color[$current_color]\">\n";
if ($group_size) { if ($group_size) {
print "<td class=\"sha1\""; print "<td class=\"sha1\"";
print " title=\"". esc_html($author) . ", $date\""; print " title=\"". esc_html($author) . ", $date\"";
@ -4667,7 +4667,6 @@ HTML
hash_base => $parent_commit); hash_base => $parent_commit);
print "<td class=\"linenr\">"; print "<td class=\"linenr\">";
print $cgi->a({ -href => "$blamed#l$orig_lineno", print $cgi->a({ -href => "$blamed#l$orig_lineno",
-id => "l$lineno",
-class => "linenr" }, -class => "linenr" },
esc_html($lineno)); esc_html($lineno));
print "</td>"; print "</td>";