undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vcs-svn: avoid self-assignment in dummy initialization of pre_off

Browse Source 
Without this change, clang complains:

 vcs-svn/svndiff.c:298:3: warning: Assigned value is garbage or undefined
                 off_t pre_off = pre_off; /* stupid GCC... */
                 ^               ~~~~~~~

This code uses an old and common idiom for suppressing an
"uninitialized variable" warning, and clang is wrong to warn about it.
The idiom tells the compiler to leave the variable uninitialized,
which saves a few bytes of code size, and, more importantly, allows
valgrind to check at runtime that the variable is properly initialized
by the time it is used.

But MSVC and clang do not know that idiom, so let's avoid it in
vcs-svn/ code.

Initialize pre_off to -1, a recognizably meaningless value, to allow
future code changes that cause pre_off to be used before it is
initialized to be caught early.

Signed-off-by: David Barr <davidbarr@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
This commit is contained in:
David Barr 2012-06-01 00:41:25 +10:00 committed by Jonathan Nieder
parent 3b8a305173
commit 4a5de8dd79
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
vcs-svn/svndiff.c
View File

@ -295,7 +295,7 @@ int svndiff0_apply(struct line_buffer *delta, off_t delta_len,
if (read_magic(delta, &delta_len)) if (read_magic(delta, &delta_len))
return -1; return -1;
while (delta_len) { /* For each window: */ while (delta_len) { /* For each window: */
off_t pre_off = pre_off; /* stupid GCC... */ off_t pre_off = -1;
size_t pre_len; size_t pre_len;
if (read_offset(delta, &pre_off, &delta_len) || if (read_offset(delta, &pre_off, &delta_len) ||