undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rebase -i: fix reflog message

Browse Source 
When rebase -i was converted to C a bug was introduced into the code
that creates the reflog message. Instead of saying
rebase -i (finish): <head-name> onto <onto>
it says
rebase -i (finish): <head-name> onto <orig-head><onto>
as the strbuf is not reset between reading the value of <orig-head>
and <onto>.

Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Phillip Wood 2017-05-18 11:02:32 +01:00 committed by Junio C Hamano
parent a42e1b4194
commit 4ab867b8fc
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sequencer.c
View File

@ -2058,6 +2058,7 @@ cleanup_head_ref:
res = error(_("could not read orig-head")); res = error(_("could not read orig-head"));
goto cleanup_head_ref; goto cleanup_head_ref;
} }
strbuf_reset(&buf);
if (!read_oneliner(&buf, rebase_path_onto(), 0)) { if (!read_oneliner(&buf, rebase_path_onto(), 0)) {
res = error(_("could not read 'onto'")); res = error(_("could not read 'onto'"));
goto cleanup_head_ref; goto cleanup_head_ref;