undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

real_path: have callers use real_pathdup and strbuf_realpath

Browse Source 
Migrate callers of real_path() who duplicate the retern value to use
real_pathdup or strbuf_realpath.

Signed-off-by: Brandon Williams <bmwill@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Brandon Williams 2016-12-12 10:16:55 -08:00 committed by Junio C Hamano
parent 7241764076
commit 4ac9006f83
7 changed files with 16 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
builtin/init-db.c
View File

@ -338,7 +338,7 @@ int init_db(const char *git_dir, const char *real_git_dir,
{ {
int reinit; int reinit;
int exist_ok = flags & INIT_DB_EXIST_OK; int exist_ok = flags & INIT_DB_EXIST_OK;
char *original_git_dir = xstrdup(real_path(git_dir)); char *original_git_dir = real_pathdup(git_dir);
if (real_git_dir) { if (real_git_dir) {
struct stat st; struct stat st;
@ -489,7 +489,7 @@ int cmd_init_db(int argc, const char **argv, const char *prefix)
argc = parse_options(argc, argv, prefix, init_db_options, init_db_usage, 0); argc = parse_options(argc, argv, prefix, init_db_options, init_db_usage, 0);
if (real_git_dir && !is_absolute_path(real_git_dir)) if (real_git_dir && !is_absolute_path(real_git_dir))
real_git_dir = xstrdup(real_path(real_git_dir)); real_git_dir = real_pathdup(real_git_dir);
if (argc == 1) { if (argc == 1) {
int mkdir_tried = 0; int mkdir_tried = 0;
@ -560,7 +560,7 @@ int cmd_init_db(int argc, const char **argv, const char *prefix)
const char *git_dir_parent = strrchr(git_dir, '/'); const char *git_dir_parent = strrchr(git_dir, '/');
if (git_dir_parent) { if (git_dir_parent) {
char *rel = xstrndup(git_dir, git_dir_parent - git_dir); char *rel = xstrndup(git_dir, git_dir_parent - git_dir);
git_work_tree_cfg = xstrdup(real_path(rel)); git_work_tree_cfg = real_pathdup(rel);
free(rel); free(rel);
} }
if (!git_work_tree_cfg) if (!git_work_tree_cfg)

2
environment.c
View File

@ -259,7 +259,7 @@ void set_git_work_tree(const char *new_work_tree)
return; return;
} }
git_work_tree_initialized = 1; git_work_tree_initialized = 1;
work_tree = xstrdup(real_path(new_work_tree)); work_tree = real_pathdup(new_work_tree);
} }
const char *get_git_work_tree(void) const char *get_git_work_tree(void)

13
setup.c
View File

@ -256,8 +256,10 @@ int get_common_dir_noenv(struct strbuf *sb, const char *gitdir)
strbuf_addbuf(&path, &data); strbuf_addbuf(&path, &data);
strbuf_addstr(sb, real_path(path.buf)); strbuf_addstr(sb, real_path(path.buf));
ret = 1; ret = 1;
} else } else {
strbuf_addstr(sb, gitdir); strbuf_addstr(sb, gitdir);
}
strbuf_release(&data); strbuf_release(&data);
strbuf_release(&path); strbuf_release(&path);
return ret; return ret;
@ -692,7 +694,7 @@ static const char *setup_discovered_git_dir(const char *gitdir,
/* --work-tree is set without --git-dir; use discovered one */ /* --work-tree is set without --git-dir; use discovered one */
if (getenv(GIT_WORK_TREE_ENVIRONMENT) || git_work_tree_cfg) { if (getenv(GIT_WORK_TREE_ENVIRONMENT) || git_work_tree_cfg) {
if (offset != cwd->len && !is_absolute_path(gitdir)) if (offset != cwd->len && !is_absolute_path(gitdir))
gitdir = xstrdup(real_path(gitdir)); gitdir = real_pathdup(gitdir);
if (chdir(cwd->buf)) if (chdir(cwd->buf))
die_errno("Could not come back to cwd"); die_errno("Could not come back to cwd");
return setup_explicit_git_dir(gitdir, cwd, nongit_ok); return setup_explicit_git_dir(gitdir, cwd, nongit_ok);
@ -800,11 +802,12 @@ static int canonicalize_ceiling_entry(struct string_list_item *item,
/* Keep entry but do not canonicalize it */ /* Keep entry but do not canonicalize it */
return 1; return 1;
} else { } else {
const char *real_path = real_path_if_valid(ceil); char *real_path = real_pathdup(ceil);
if (!real_path) if (!real_path) {
return 0; return 0;
}
free(item->string); free(item->string);
item->string = xstrdup(real_path); item->string = real_path;
return 1; return 1;
} }
} }

2
sha1_file.c
View File

@ -291,7 +291,7 @@ static int link_alt_odb_entry(const char *entry, const char *relative_base,
struct strbuf pathbuf = STRBUF_INIT; struct strbuf pathbuf = STRBUF_INIT;
if (!is_absolute_path(entry) && relative_base) { if (!is_absolute_path(entry) && relative_base) {
strbuf_addstr(&pathbuf, real_path(relative_base)); strbuf_realpath(&pathbuf, relative_base, 1);
strbuf_addch(&pathbuf, '/'); strbuf_addch(&pathbuf, '/');
} }
strbuf_addstr(&pathbuf, entry); strbuf_addstr(&pathbuf, entry);

2
submodule.c
View File

@ -1227,7 +1227,7 @@ void connect_work_tree_and_git_dir(const char *work_tree, const char *git_dir)
{ {
struct strbuf file_name = STRBUF_INIT; struct strbuf file_name = STRBUF_INIT;
struct strbuf rel_path = STRBUF_INIT; struct strbuf rel_path = STRBUF_INIT;
const char *real_work_tree = xstrdup(real_path(work_tree)); const char *real_work_tree = real_pathdup(work_tree);
/* Update gitfile */ /* Update gitfile */
strbuf_addf(&file_name, "%s/.git", work_tree); strbuf_addf(&file_name, "%s/.git", work_tree);

2
transport.c
View File

@ -1130,7 +1130,7 @@ static int refs_from_alternate_cb(struct alternate_object_database *e,
const struct ref *extra; const struct ref *extra;
struct alternate_refs_data *cb = data; struct alternate_refs_data *cb = data;
other = xstrdup(real_path(e->path)); other = real_pathdup(e->path);
len = strlen(other); len = strlen(other);
while (other[len-1] == '/') while (other[len-1] == '/')

2
worktree.c
View File

@ -255,7 +255,7 @@ struct worktree *find_worktree(struct worktree **list,
return wt; return wt;
arg = prefix_filename(prefix, strlen(prefix), arg); arg = prefix_filename(prefix, strlen(prefix), arg);
path = xstrdup(real_path(arg)); path = real_pathdup(arg);
for (; *list; list++) for (; *list; list++)
if (!fspathcmp(path, real_path((*list)->path))) if (!fspathcmp(path, real_path((*list)->path)))
break; break;