undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

wildmatch test: use test_must_fail, not ! for test-wildmatch

Browse Source 
Use of ! should be reserved for non-git programs that are assumed not
to fail, see README. With this change only
t/t0110-urlmatch-normalization.sh is still using this anti-pattern.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ævar Arnfjörð Bjarmason 2018-01-30 21:21:20 +00:00 committed by Junio C Hamano
parent 50eafb1a27
commit 4bc280f250
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
t/t3070-wildmatch.sh
View File

@ -13,7 +13,7 @@ match() {
elif test "$1" = 0 elif test "$1" = 0
then then
test_expect_success "wildmatch: no match '$2' '$3'" " test_expect_success "wildmatch: no match '$2' '$3'" "
! test-wildmatch wildmatch '$2' '$3' test_must_fail test-wildmatch wildmatch '$2' '$3'
" "
else else
test_expect_success "PANIC: Test framework error. Unknown matches value $1" 'false' test_expect_success "PANIC: Test framework error. Unknown matches value $1" 'false'
@ -29,7 +29,7 @@ imatch() {
elif test "$1" = 0 elif test "$1" = 0
then then
test_expect_success "iwildmatch: no match '$2' '$3'" " test_expect_success "iwildmatch: no match '$2' '$3'" "
! test-wildmatch iwildmatch '$2' '$3' test_must_fail test-wildmatch iwildmatch '$2' '$3'
" "
else else
test_expect_success "PANIC: Test framework error. Unknown matches value $1" 'false' test_expect_success "PANIC: Test framework error. Unknown matches value $1" 'false'
@ -45,7 +45,7 @@ pathmatch() {
elif test "$1" = 0 elif test "$1" = 0
then then
test_expect_success "pathmatch: no match '$2' '$3'" " test_expect_success "pathmatch: no match '$2' '$3'" "
! test-wildmatch pathmatch '$2' '$3' test_must_fail test-wildmatch pathmatch '$2' '$3'
" "
else else
test_expect_success "PANIC: Test framework error. Unknown matches value $1" 'false' test_expect_success "PANIC: Test framework error. Unknown matches value $1" 'false'