undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'kt/commit-graph-plug-fp-leak-on-error'

Browse Source 
Fix a leak of FILE * in an error codepath.

* kt/commit-graph-plug-fp-leak-on-error:
  commit-graph: close file before returning NULL
This commit is contained in:
Junio C Hamano 2022-05-11 13:56:22 -07:00
commit 4c5d5e1b72
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
commit-graph.c
View File

@ -523,10 +523,13 @@ static struct commit_graph *load_commit_graph_chain(struct repository *r,
stat_res = stat(chain_name, &st);
free(chain_name);
if (!fp ||
stat_res ||
st.st_size <= the_hash_algo->hexsz)
if (!fp)
return NULL;
if (stat_res ||
st.st_size <= the_hash_algo->hexsz) {
fclose(fp);
return NULL;
}
count = st.st_size / (the_hash_algo->hexsz + 1);
CALLOC_ARRAY(oids, count);