undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-p4: open temporary patch file for write only

Browse Source 
The patchRCSKeywords method creates a temporary file in which to store
the patched output data. Previously this file was opened in "w+" mode
(write and read), but the code never reads the contents of the file
while open, so it only needs to be opened in "w" mode (write-only).

Signed-off-by: Joel Holdsworth <jholdsworth@nvidia.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Joel Holdsworth 2021-12-16 13:46:18 +00:00 committed by Junio C Hamano
parent 9732e2229c
commit 4cf67ae1b6
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
git-p4.py
View File

@ -1754,7 +1754,7 @@ class P4Submit(Command, P4UserMap):
# Attempt to zap the RCS keywords in a p4 controlled file matching the given regex
(handle, outFileName) = tempfile.mkstemp(dir='.')
try:
with os.fdopen(handle, "w+") as outFile, open(file, "r") as inFile:
with os.fdopen(handle, "w") as outFile, open(file, "r") as inFile:
for line in inFile.readlines():
outFile.write(regexp.sub(r'$\1$', line))
# Forcibly overwrite the original file