undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

http: drop http_error function

Browse Source 
This function is a single-liner and is only called from one
place. Just inline it, which makes the code more obvious.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2013-04-05 18:22:31 -04:00 committed by Junio C Hamano
parent de89f0b25a
commit 4df13f69e9
3 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
http-push.c
View File

@ -1551,7 +1551,7 @@ static int remote_exists(const char *path)
ret = 0; ret = 0;
break; break;
case HTTP_ERROR: case HTTP_ERROR:
http_error(url); error("unable to access '%s': %s", url, curl_errorstr);
default: default:
ret = -1; ret = -1;
} }

5
http.c
View File

@ -941,11 +941,6 @@ cleanup:
return ret; return ret;
} }
void http_error(const char *url)
{
error("unable to access '%s': %s", url, curl_errorstr);
}
int http_fetch_ref(const char *base, struct ref *ref) int http_fetch_ref(const char *base, struct ref *ref)
{ {
char *url; char *url;

5
http.h
View File

@ -135,11 +135,6 @@ extern char *get_remote_object_url(const char *url, const char *hex,
*/ */
int http_get_strbuf(const char *url, struct strbuf *content_type, struct strbuf *result, int options); int http_get_strbuf(const char *url, struct strbuf *content_type, struct strbuf *result, int options);
/*
* Prints an error message using error() containing url and curl_errorstr.
*/
void http_error(const char *url);
extern int http_fetch_ref(const char *base, struct ref *ref); extern int http_fetch_ref(const char *base, struct ref *ref);
/* Helpers for fetching packs */ /* Helpers for fetching packs */