undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'jk/diffstat-binary' into maint

Browse Source 
* jk/diffstat-binary:
  diff: don't retrieve binary blobs for diffstat
  diff: handle diffstat of rewritten binary files
This commit is contained in:
Junio C Hamano 2011-03-16 16:47:26 -07:00
commit 4e530c5049
2 changed files with 28 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
diff.c
View File

@ -245,6 +245,15 @@ static int fill_mmfile(mmfile_t *mf, struct diff_filespec *one)
return 0; return 0;
} }
/* like fill_mmfile, but only for size, so we can avoid retrieving blob */
static unsigned long diff_filespec_size(struct diff_filespec *one)
{
if (!DIFF_FILE_VALID(one))
return 0;
diff_populate_filespec(one, 1);
return one->size;
}
static int count_trailing_blank(mmfile_t *mf, unsigned ws_rule) static int count_trailing_blank(mmfile_t *mf, unsigned ws_rule)
{ {
char *ptr = mf->ptr; char *ptr = mf->ptr;
@ -2077,25 +2086,28 @@ static void builtin_diffstat(const char *name_a, const char *name_b,
data->is_unmerged = 1; data->is_unmerged = 1;
return; return;
} }
if (complete_rewrite) {
if (diff_filespec_is_binary(one) || diff_filespec_is_binary(two)) {
data->is_binary = 1;
data->added = diff_filespec_size(two);
data->deleted = diff_filespec_size(one);
}
else if (complete_rewrite) {
diff_populate_filespec(one, 0); diff_populate_filespec(one, 0);
diff_populate_filespec(two, 0); diff_populate_filespec(two, 0);
data->deleted = count_lines(one->data, one->size); data->deleted = count_lines(one->data, one->size);
data->added = count_lines(two->data, two->size); data->added = count_lines(two->data, two->size);
goto free_and_return;
} }
if (fill_mmfile(&mf1, one) < 0 || fill_mmfile(&mf2, two) < 0)
die("unable to read files to diff");
if (diff_filespec_is_binary(one) || diff_filespec_is_binary(two)) { else {
data->is_binary = 1;
data->added = mf2.size;
data->deleted = mf1.size;
} else {
/* Crazy xdl interfaces.. */ /* Crazy xdl interfaces.. */
xpparam_t xpp; xpparam_t xpp;
xdemitconf_t xecfg; xdemitconf_t xecfg;
if (fill_mmfile(&mf1, one) < 0 || fill_mmfile(&mf2, two) < 0)
die("unable to read files to diff");
memset(&xpp, 0, sizeof(xpp)); memset(&xpp, 0, sizeof(xpp));
memset(&xecfg, 0, sizeof(xecfg)); memset(&xecfg, 0, sizeof(xecfg));
xpp.flags = o->xdl_opts; xpp.flags = o->xdl_opts;
@ -2103,7 +2115,6 @@ static void builtin_diffstat(const char *name_a, const char *name_b,
&xpp, &xecfg); &xpp, &xecfg);
} }
free_and_return:
diff_free_filespec_data(one); diff_free_filespec_data(one);
diff_free_filespec_data(two); diff_free_filespec_data(two);
} }

7
t/t4031-diff-rewrite-binary.sh
View File

@ -44,6 +44,13 @@ test_expect_success 'rewrite diff can show binary patch' '
grep "GIT binary patch" diff grep "GIT binary patch" diff
' '
test_expect_success 'rewrite diff --stat shows binary changes' '
git diff -B --stat --summary >diff &&
grep "Bin" diff &&
grep "0 insertions.*0 deletions" diff &&
grep " rewrite file" diff
'
{ {
echo "#!$SHELL_PATH" echo "#!$SHELL_PATH"
cat <<'EOF' cat <<'EOF'