undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'jk/fail-null-clone'

Browse Source 
* jk/fail-null-clone:
  clone: die when trying to clone missing local path
This commit is contained in:
Junio C Hamano 2011-03-04 15:02:26 -08:00
commit 51aca1665b
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
builtin/clone.c
View File

@ -413,7 +413,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
if (path) if (path)
repo = xstrdup(make_nonrelative_path(repo_name)); repo = xstrdup(make_nonrelative_path(repo_name));
else if (!strchr(repo_name, ':')) else if (!strchr(repo_name, ':'))
repo = xstrdup(make_absolute_path(repo_name)); die("repository '%s' does not exist", repo_name);
else else
repo = repo_name; repo = repo_name;
is_local = path && !is_bundle; is_local = path && !is_bundle;

13
t/t5701-clone-local.sh
View File

@ -144,4 +144,17 @@ test_expect_success 'clone empty repository, and then push should not segfault.'
test_must_fail git push) test_must_fail git push)
' '
test_expect_success 'cloning non-existent directory fails' '
cd "$D" &&
rm -rf does-not-exist &&
test_must_fail git clone does-not-exist
'
test_expect_success 'cloning non-git directory fails' '
cd "$D" &&
rm -rf not-a-git-repo not-a-git-repo-clone &&
mkdir not-a-git-repo &&
test_must_fail git clone not-a-git-repo not-a-git-repo-clone
'
test_done test_done