undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

New files in git weren't being downloaded during CVS update

Browse Source 
If a repository was checked out via git-cvsserver and then later a new
file is added to the git repository via some other method; a CVS update
wasn't fetching the new file.

It would be reported as a new file as
 A some/dir/newfile.c
but would never appear in the directory.

The problem seems to be that git-cvsserver was treating these two cases
identically, as "A" type results.

1. New file in repository
2. New file locally

In fact, traditionally, case 1 is treated as a "U" result, and case 2
only is treated as an "A" result.  "A", should just report that the file
is added locally and then skip that file during an update as there is
(of course) nothing to send.

In both these cases there is no working revision, so the checking for
"is there no working revision" will return true.  The test for case 2
needs refining to say "if there is no working revision and no upstream
revision".  This patch does just that, leaving case 1 to be handled by
the normal "U" handler.

I've also updated the log message to more accurately describe the
operation.  i.e. that "A" means that content is scheduled for addition;
not that it actually has been added.

Signed-off-by: Andy Parkins <andyparkins@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Andy Parkins 2007-01-22 10:56:27 +00:00 committed by Junio C Hamano
parent 5dee29ac0f
commit 535514f1f3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
git-cvsserver.perl
View File

@ -876,9 +876,9 @@ sub req_update
print "MT newline\n"; print "MT newline\n";
next; next;
} }
elsif ( !defined($wrev) || $wrev == 0 ) elsif ( (!defined($wrev) || $wrev == 0) && (!defined($meta->{revision}) || $meta->{revision} == 0) )
{ {
$log->info("Tell the client the file will be added"); $log->info("Tell the client the file is scheduled for addition");
print "MT text A \n"; print "MT text A \n";
print "MT fname $filename\n"; print "MT fname $filename\n";
print "MT newline\n"; print "MT newline\n";
@ -886,7 +886,7 @@ sub req_update
} }
else { else {
$log->info("Updating '$filename' $wrev"); $log->info("Updating '$filename' to ".$meta->{revision});
print "MT +updated\n"; print "MT +updated\n";
print "MT text U \n"; print "MT text U \n";
print "MT fname $filename\n"; print "MT fname $filename\n";