undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

compat/setenv.c: update errno when erroring out

Browse Source 
Previously, gitsetenv didn't update errno as it should when
erroring out. Fix this.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Erik Faye-Lund 2011-12-14 15:07:08 +01:00 committed by Junio C Hamano
parent 10dd3b2bf1
commit 57590c72b4
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
compat/setenv.c
View File

@ -6,7 +6,10 @@ int gitsetenv(const char *name, const char *value, int replace)
size_t namelen, valuelen; size_t namelen, valuelen;
char *envstr; char *envstr;
if (!name || !value) return -1; if (!name || !value) {
errno = EINVAL;
return -1;
}
if (!replace) { if (!replace) {
char *oldval = NULL; char *oldval = NULL;
oldval = getenv(name); oldval = getenv(name);
@ -16,7 +19,10 @@ int gitsetenv(const char *name, const char *value, int replace)
namelen = strlen(name); namelen = strlen(name);
valuelen = strlen(value); valuelen = strlen(value);
envstr = malloc((namelen + valuelen + 2)); envstr = malloc((namelen + valuelen + 2));
if (!envstr) return -1; if (!envstr) {
errno = ENOMEM;
return -1;
}
memcpy(envstr, name, namelen); memcpy(envstr, name, namelen);
envstr[namelen] = '='; envstr[namelen] = '=';