undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

core: Stop leaking ondisk_cache_entrys

Browse Source 
Noticed with valgrind.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jonathan Nieder 2010-08-09 22:28:07 -05:00 committed by Junio C Hamano
parent 64fdc08dac
commit 59efba64ac
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
read-cache.c
View File

@ -1516,6 +1516,7 @@ static int ce_write_entry(git_SHA_CTX *c, int fd, struct cache_entry *ce)
int size = ondisk_ce_size(ce); int size = ondisk_ce_size(ce);
struct ondisk_cache_entry *ondisk = xcalloc(1, size); struct ondisk_cache_entry *ondisk = xcalloc(1, size);
char *name; char *name;
int result;
ondisk->ctime.sec = htonl(ce->ce_ctime.sec); ondisk->ctime.sec = htonl(ce->ce_ctime.sec);
ondisk->mtime.sec = htonl(ce->ce_mtime.sec); ondisk->mtime.sec = htonl(ce->ce_mtime.sec);
@ -1539,7 +1540,9 @@ static int ce_write_entry(git_SHA_CTX *c, int fd, struct cache_entry *ce)
name = ondisk->name; name = ondisk->name;
memcpy(name, ce->name, ce_namelen(ce)); memcpy(name, ce->name, ce_namelen(ce));
return ce_write(c, fd, ondisk, size); result = ce_write(c, fd, ondisk, size);
free(ondisk);
return result;
} }
int write_index(struct index_state *istate, int newfd) int write_index(struct index_state *istate, int newfd)