undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

commit: improve error message in "-a <paths>" case

Browse Source 
I did something stupid today and got

    $ git commit -a --fixup= @^
    fatal: Paths with -a does not make sense.

which didn't make any sense (at least for the first few seconds).

Include the first path(spec) in the error message to help spot the
problem quicker. Now it shows

    fatal: paths '@^ ...' with -a does not make sense

which should ring some bell because @^ should clearly not be considered
a path.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Nguyễn Thái Ngọc Duy 2019-03-20 17:29:06 +07:00 committed by Junio C Hamano
parent aeb582a983
commit 5a1dbd48bc
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
builtin/commit.c
View File

@ -1185,7 +1185,8 @@ static int parse_and_validate_options(int argc, const char *argv[],
handle_untracked_files_arg(s);
if (all && argc > 0)
die(_("Paths with -a does not make sense."));
die(_("paths '%s ...' with -a does not make sense"),
argv[0]);
if (status_format != STATUS_FORMAT_NONE)
dry_run = 1;