Revert "Merge branch 'cb/maint-quiet-push' into maint"

This reverts commit ffa69e61d3, reversing
changes made to 4a13c4d148.

Adding a new command line option to receive-pack and feed it from
send-pack is not an acceptable way to add features, as there is no
guarantee that your updated send-pack will be talking to updated
receive-pack. New features need to be added via the capability mechanism
negotiated over the protocol.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano 2011-09-06 11:06:32 -07:00
parent b15b5b10a7
commit 5a277f3ff7
6 changed files with 10 additions and 39 deletions

View File

@ -9,7 +9,7 @@ git-receive-pack - Receive what is pushed into the repository
SYNOPSIS SYNOPSIS
-------- --------
[verse] [verse]
'git-receive-pack' [--quiet] <directory> 'git-receive-pack' <directory>
DESCRIPTION DESCRIPTION
----------- -----------
@ -35,9 +35,6 @@ are not fast-forwards.
OPTIONS OPTIONS
------- -------
--quiet::
Print only error messages.
<directory>:: <directory>::
The repository to sync into. The repository to sync into.

View File

@ -9,7 +9,7 @@ git-send-pack - Push objects over git protocol to another repository
SYNOPSIS SYNOPSIS
-------- --------
[verse] [verse]
'git send-pack' [--all] [--dry-run] [--force] [--receive-pack=<git-receive-pack>] [--quiet] [--verbose] [--thin] [<host>:]<directory> [<ref>...] 'git send-pack' [--all] [--dry-run] [--force] [--receive-pack=<git-receive-pack>] [--verbose] [--thin] [<host>:]<directory> [<ref>...]
DESCRIPTION DESCRIPTION
----------- -----------
@ -45,9 +45,6 @@ OPTIONS
the remote repository can lose commits; use it with the remote repository can lose commits; use it with
care. care.
--quiet::
Print only error messages.
--verbose:: --verbose::
Run verbosely. Run verbosely.

View File

@ -636,7 +636,7 @@ static const char *parse_pack_header(struct pack_header *hdr)
static const char *pack_lockfile; static const char *pack_lockfile;
static const char *unpack(int quiet) static const char *unpack(void)
{ {
struct pack_header hdr; struct pack_header hdr;
const char *hdr_err; const char *hdr_err;
@ -651,10 +651,8 @@ static const char *unpack(int quiet)
if (ntohl(hdr.hdr_entries) < unpack_limit) { if (ntohl(hdr.hdr_entries) < unpack_limit) {
int code, i = 0; int code, i = 0;
const char *unpacker[5]; const char *unpacker[4];
unpacker[i++] = "unpack-objects"; unpacker[i++] = "unpack-objects";
if (quiet)
unpacker[i++] = "-q";
if (receive_fsck_objects) if (receive_fsck_objects)
unpacker[i++] = "--strict"; unpacker[i++] = "--strict";
unpacker[i++] = hdr_arg; unpacker[i++] = hdr_arg;
@ -755,7 +753,6 @@ static void add_alternate_refs(void)
int cmd_receive_pack(int argc, const char **argv, const char *prefix) int cmd_receive_pack(int argc, const char **argv, const char *prefix)
{ {
int quiet = 0;
int advertise_refs = 0; int advertise_refs = 0;
int stateless_rpc = 0; int stateless_rpc = 0;
int i; int i;
@ -769,11 +766,6 @@ int cmd_receive_pack(int argc, const char **argv, const char *prefix)
const char *arg = *argv++; const char *arg = *argv++;
if (*arg == '-') { if (*arg == '-') {
if (!strcmp(arg, "--quiet")) {
quiet = 1;
continue;
}
if (!strcmp(arg, "--advertise-refs")) { if (!strcmp(arg, "--advertise-refs")) {
advertise_refs = 1; advertise_refs = 1;
continue; continue;
@ -822,7 +814,7 @@ int cmd_receive_pack(int argc, const char **argv, const char *prefix)
const char *unpack_status = NULL; const char *unpack_status = NULL;
if (!delete_only(commands)) if (!delete_only(commands))
unpack_status = unpack(quiet); unpack_status = unpack();
execute_commands(commands, unpack_status); execute_commands(commands, unpack_status);
if (pack_lockfile) if (pack_lockfile)
unlink_or_warn(pack_lockfile); unlink_or_warn(pack_lockfile);

View File

@ -439,10 +439,6 @@ int cmd_send_pack(int argc, const char **argv, const char *prefix)
args.force_update = 1; args.force_update = 1;
continue; continue;
} }
if (!strcmp(arg, "--quiet")) {
args.quiet = 1;
continue;
}
if (!strcmp(arg, "--verbose")) { if (!strcmp(arg, "--verbose")) {
args.verbose = 1; args.verbose = 1;
continue; continue;
@ -492,13 +488,8 @@ int cmd_send_pack(int argc, const char **argv, const char *prefix)
fd[0] = 0; fd[0] = 0;
fd[1] = 1; fd[1] = 1;
} else { } else {
struct strbuf sb = STRBUF_INIT; conn = git_connect(fd, dest, receivepack,
strbuf_addstr(&sb, receivepack);
if (args.quiet)
strbuf_addstr(&sb, " --quiet");
conn = git_connect(fd, dest, sb.buf,
args.verbose ? CONNECT_VERBOSE : 0); args.verbose ? CONNECT_VERBOSE : 0);
strbuf_release(&sb);
} }
memset(&extra_have, 0, sizeof(extra_have)); memset(&extra_have, 0, sizeof(extra_have));

View File

@ -762,9 +762,7 @@ static int push_git(struct discovery *heads, int nr_spec, char **specs)
argv[argc++] = "--thin"; argv[argc++] = "--thin";
if (options.dry_run) if (options.dry_run)
argv[argc++] = "--dry-run"; argv[argc++] = "--dry-run";
if (options.verbosity < 0) if (options.verbosity > 1)
argv[argc++] = "--quiet";
else if (options.verbosity > 1)
argv[argc++] = "--verbose"; argv[argc++] = "--verbose";
argv[argc++] = url; argv[argc++] = url;
for (i = 0; i < nr_spec; i++) for (i = 0; i < nr_spec; i++)

View File

@ -482,18 +482,14 @@ static int set_git_option(struct git_transport_options *opts,
static int connect_setup(struct transport *transport, int for_push, int verbose) static int connect_setup(struct transport *transport, int for_push, int verbose)
{ {
struct git_transport_data *data = transport->data; struct git_transport_data *data = transport->data;
struct strbuf sb = STRBUF_INIT;
if (data->conn) if (data->conn)
return 0; return 0;
strbuf_addstr(&sb, for_push ? data->options.receivepack : data->conn = git_connect(data->fd, transport->url,
data->options.uploadpack); for_push ? data->options.receivepack :
if (for_push && transport->verbose < 0) data->options.uploadpack,
strbuf_addstr(&sb, " --quiet");
data->conn = git_connect(data->fd, transport->url, sb.buf,
verbose ? CONNECT_VERBOSE : 0); verbose ? CONNECT_VERBOSE : 0);
strbuf_release(&sb);
return 0; return 0;
} }