undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

diff-index: restore -c/--cc options handling

Browse Source 
This fixes 19b2517f (diff-merges: move specific diff-index "-m"
handling to diff-index, 2021-05-21).

That commit disabled handling of all diff for merges options in
diff-index on an assumption that they are unused. However, it later
appeared that -c and --cc, even though undocumented and not being
covered by tests, happen to have had particular effect on diff-index
output.

Restore original -c/--cc options handling by diff-index.

Signed-off-by: Sergey Organov <sorganov@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Sergey Organov 2021-09-01 19:52:20 +03:00 committed by Junio C Hamano
parent 225bc32a98
commit 5acffd3473
3 changed files with 8 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
builtin/diff-index.c
View File

@ -29,10 +29,10 @@ int cmd_diff_index(int argc, const char **argv, const char *prefix)
prefix = precompose_argv_prefix(argc, argv, prefix); prefix = precompose_argv_prefix(argc, argv, prefix);
/* /*
* We need no diff for merges options, and we need to avoid conflict * We need (some of) diff for merges options (e.g., --cc), and we need
* with our own meaning of "-m". * to avoid conflict with our own meaning of "-m".
*/ */
diff_merges_suppress_options_parsing(); diff_merges_suppress_m_parsing();
argc = setup_revisions(argc, argv, &rev, NULL); argc = setup_revisions(argc, argv, &rev, NULL);
for (i = 1; i < argc; i++) { for (i = 1; i < argc; i++) {

14
diff-merges.c
View File

@ -6,7 +6,7 @@ typedef void (*diff_merges_setup_func_t)(struct rev_info *);
static void set_separate(struct rev_info *revs); static void set_separate(struct rev_info *revs);
static diff_merges_setup_func_t set_to_default = set_separate; static diff_merges_setup_func_t set_to_default = set_separate;
static int suppress_parsing; static int suppress_m_parsing;
static void suppress(struct rev_info *revs) static void suppress(struct rev_info *revs)
{ {
@ -91,9 +91,9 @@ int diff_merges_config(const char *value)
return 0; return 0;
} }
void diff_merges_suppress_options_parsing(void) void diff_merges_suppress_m_parsing(void)
{ {
suppress_parsing = 1; suppress_m_parsing = 1;
} }
int diff_merges_parse_opts(struct rev_info *revs, const char **argv) int diff_merges_parse_opts(struct rev_info *revs, const char **argv)
@ -102,10 +102,7 @@ int diff_merges_parse_opts(struct rev_info *revs, const char **argv)
const char *optarg; const char *optarg;
const char *arg = argv[0]; const char *arg = argv[0];
if (suppress_parsing) if (!suppress_m_parsing && !strcmp(arg, "-m")) {
return 0;
if (!strcmp(arg, "-m")) {
set_to_default(revs); set_to_default(revs);
} else if (!strcmp(arg, "-c")) { } else if (!strcmp(arg, "-c")) {
set_combined(revs); set_combined(revs);
@ -153,9 +150,6 @@ void diff_merges_set_dense_combined_if_unset(struct rev_info *revs)
void diff_merges_setup_revs(struct rev_info *revs) void diff_merges_setup_revs(struct rev_info *revs)
{ {
if (suppress_parsing)
return;
if (revs->combine_merges == 0) if (revs->combine_merges == 0)
revs->dense_combined_merges = 0; revs->dense_combined_merges = 0;
if (revs->separate_merges == 0) if (revs->separate_merges == 0)

2
diff-merges.h
View File

@ -11,7 +11,7 @@ struct rev_info;
int diff_merges_config(const char *value); int diff_merges_config(const char *value);
void diff_merges_suppress_options_parsing(void); void diff_merges_suppress_m_parsing(void);
int diff_merges_parse_opts(struct rev_info *revs, const char **argv); int diff_merges_parse_opts(struct rev_info *revs, const char **argv);