undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

update-ref: drop unused argument for parse_refname

Browse Source 
The `parse_refname` function accepts a `struct strbuf *input` argument
that isn't used at all. As we're about to convert commands to not use a
strbuf anymore but instead an end pointer, let's drop this argument now
to make the converting commit easier to review.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Patrick Steinhardt 2020-04-02 09:09:43 +02:00 committed by Junio C Hamano
parent a65b8ac291
commit 5ae6c5a712
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
builtin/update-ref.c
View File

@ -50,7 +50,7 @@ static const char *parse_arg(const char *next, struct strbuf *arg)
* the argument. Die if C-quoting is malformed or the reference name * the argument. Die if C-quoting is malformed or the reference name
* is invalid. * is invalid.
*/ */
static char *parse_refname(struct strbuf *input, const char **next) static char *parse_refname(const char **next)
{ {
struct strbuf ref = STRBUF_INIT; struct strbuf ref = STRBUF_INIT;
@ -186,7 +186,7 @@ static const char *parse_cmd_update(struct ref_transaction *transaction,
struct object_id new_oid, old_oid; struct object_id new_oid, old_oid;
int have_old; int have_old;
refname = parse_refname(input, &next); refname = parse_refname(&next);
if (!refname) if (!refname)
die("update: missing <ref>"); die("update: missing <ref>");
@ -220,7 +220,7 @@ static const char *parse_cmd_create(struct ref_transaction *transaction,
char *refname; char *refname;
struct object_id new_oid; struct object_id new_oid;
refname = parse_refname(input, &next); refname = parse_refname(&next);
if (!refname) if (!refname)
die("create: missing <ref>"); die("create: missing <ref>");
@ -253,7 +253,7 @@ static const char *parse_cmd_delete(struct ref_transaction *transaction,
struct object_id old_oid; struct object_id old_oid;
int have_old; int have_old;
refname = parse_refname(input, &next); refname = parse_refname(&next);
if (!refname) if (!refname)
die("delete: missing <ref>"); die("delete: missing <ref>");
@ -288,7 +288,7 @@ static const char *parse_cmd_verify(struct ref_transaction *transaction,
char *refname; char *refname;
struct object_id old_oid; struct object_id old_oid;
refname = parse_refname(input, &next); refname = parse_refname(&next);
if (!refname) if (!refname)
die("verify: missing <ref>"); die("verify: missing <ref>");