undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

diff tests: don't ignore "git rev-list" exit code

Browse Source 
Change a fragile pattern introduced in 2b459b483c (diff: make sure
work tree side is shown as 0{40} when different, 2008-03-02) to check
the exit code of "git rev-list", while we're at it let's get rid of
the needless sub-shell for invoking it in favor of the "-C" option.

Because of this I'd marked these tests as passing under SANITIZE=leak
in 16d4bd4f14 (leak tests: mark some diff tests as passing with
SANITIZE=leak, 2021-10-31), let's remove the
"TEST_PASSES_SANITIZE_LEAK=true" annotation as they no longer do.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ævar Arnfjörð Bjarmason 2022-03-07 13:49:01 +01:00 committed by Junio C Hamano
parent b6d775dd38
commit 5b911a29ff
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
t/t4027-diff-submodule.sh
View File

@ -2,7 +2,6 @@
test_description='difference in submodules' test_description='difference in submodules'
TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh . ./test-lib.sh
. "$TEST_DIRECTORY"/lib-diff.sh . "$TEST_DIRECTORY"/lib-diff.sh
@ -28,10 +27,8 @@ test_expect_success setup '
git commit -m "submodule #2" git commit -m "submodule #2"
) && ) &&
set x $( git -C sub rev-list HEAD >revs &&
cd sub && set x $(cat revs) &&
git rev-list HEAD
) &&
echo ":160000 160000 $3 $ZERO_OID M sub" >expect && echo ":160000 160000 $3 $ZERO_OID M sub" >expect &&
subtip=$3 subprev=$2 subtip=$3 subprev=$2
' '