undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: simplify counts aggregation

Browse Source 
When the list of files as input was implemented in 6508eedf67
(t/aggregate-results: accomodate systems with small max argument list
length, 2010-06-01), a much simpler solution wasn't considered.

Let's just pass the directory as an argument.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Felipe Contreras 2023-03-09 11:30:31 -06:00 committed by Junio C Hamano
parent 725f57037d
commit 5d1d62e875
3 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
contrib/subtree/t/Makefile
View File

@ -74,9 +74,7 @@ aggregate-results-and-cleanup: $(T)
$(MAKE) clean $(MAKE) clean
aggregate-results: aggregate-results:
for f in '$(TEST_RESULTS_DIRECTORY_SQ)'/t*-*.counts; do \ '$(SHELL_PATH_SQ)' ../../../t/aggregate-results.sh '$(TEST_RESULTS_DIRECTORY_SQ)'
echo "$$f"; \
done | '$(SHELL_PATH_SQ)' ../../../t/aggregate-results.sh
valgrind: valgrind:
$(MAKE) GIT_TEST_OPTS="$(GIT_TEST_OPTS) --valgrind" $(MAKE) GIT_TEST_OPTS="$(GIT_TEST_OPTS) --valgrind"

4
t/Makefile
View File

@ -140,9 +140,7 @@ aggregate-results-and-cleanup: $(T)
$(MAKE) clean $(MAKE) clean
aggregate-results: aggregate-results:
for f in '$(TEST_RESULTS_DIRECTORY_SQ)'/t*-*.counts; do \ '$(SHELL_PATH_SQ)' ./aggregate-results.sh '$(TEST_RESULTS_DIRECTORY_SQ)'
echo "$$f"; \
done | '$(SHELL_PATH_SQ)' ./aggregate-results.sh
valgrind: valgrind:
$(MAKE) GIT_TEST_OPTS="$(GIT_TEST_OPTS) --valgrind" $(MAKE) GIT_TEST_OPTS="$(GIT_TEST_OPTS) --valgrind"

2
t/aggregate-results.sh
View File

@ -8,7 +8,7 @@ broken=0
total=0 total=0
missing_prereq= missing_prereq=
while read file for file in "$1"/t*-*.counts
do do
while read type value while read type value
do do