undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

verify_one_sparse(): drop unused parameters

Browse Source 
This function has never used its repository or cache_tree parameters
since it was introduced in 9ad2d5ea71 (sparse-index: loose integration
with cache_tree_verify(), 2021-03-30).

As that commit notes, it may eventually be extended further, and that
might require looking at more data. But we can easily add them back if
necessary (and the repository is even included in the index_state these
days already). In the mean time, dropping them makes the code shorter
and appeases -Wunused-parameter.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2022-08-20 05:02:48 -04:00 committed by Junio C Hamano
parent 77651c032c
commit 5db8e59cf1
1 changed files with 2 additions and 4 deletions

6
cache-tree.c

@ -857,9 +857,7 @@ int cache_tree_matches_traversal(struct cache_tree *root,
return 0;
}
static void verify_one_sparse(struct repository *r,
struct index_state *istate,
struct cache_tree *it,
static void verify_one_sparse(struct index_state *istate,
struct strbuf *path,
int pos)
{
@ -910,7 +908,7 @@ static int verify_one(struct repository *r,
return 1;
if (pos >= 0) {
verify_one_sparse(r, istate, it, path, pos);
verify_one_sparse(istate, path, pos);
return 0;
}