undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

builtin/repack.c: extract showing progress to a variable

Browse Source 
We only ask whether stderr is a tty before calling
'prune_packed_objects()', but the subsequent patch will add another use.

Extract this check into a variable so that both can use it without
having to call 'isatty()' twice.

Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Taylor Blau 2021-09-28 21:55:15 -04:00 committed by Junio C Hamano
parent a169166d2b
commit 5f18e31f46
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
builtin/repack.c
View File

@ -446,6 +446,7 @@ int cmd_repack(int argc, const char **argv, const char *prefix)
struct strbuf line = STRBUF_INIT;
int i, ext, ret;
FILE *out;
int show_progress = isatty(2);
/* variables to be filled by option parsing */
int pack_everything = 0;
@ -719,7 +720,7 @@ int cmd_repack(int argc, const char **argv, const char *prefix)
}
strbuf_release(&buf);
}
if (!po_args.quiet && isatty(2))
if (!po_args.quiet && show_progress)
opts |= PRUNE_PACKED_VERBOSE;
prune_packed_objects(opts);