undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use strlcpy instead of strncpy in mailmap.c

Browse Source 
strncpy does not NUL-terminate output in case of output buffer too short,
and map_email prototype (and usage) does not allow for figuring out
what the length of the name is.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Alex Riesen 2007-05-01 00:22:53 +02:00 committed by Junio C Hamano
parent a07157ac62
commit 600682aaa1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mailmap.c
View File

@ -80,7 +80,7 @@ int map_email(struct path_list *map, const char *email, char *name, int maxlen)
free(mailbuf); free(mailbuf);
if (item != NULL) { if (item != NULL) {
const char *realname = (const char *)item->util; const char *realname = (const char *)item->util;
strncpy(name, realname, maxlen); strlcpy(name, realname, maxlen);
return 1; return 1;
} }
return 0; return 0;