undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

builtin/clone.c: detect a clone starting at a tag correctly

Browse Source 
31b808a0 (clone --single: limit the fetch refspec to fetched branch,
2012-09-20) tried to see if the given "branch" to follow is actually
a tag at the remote repository by checking with "refs/tags/" but it
incorrectly used strstr(3); it is actively wrong to treat a "branch"
"refs/heads/refs/tags/foo" and use the logic for the "refs/tags/"
ref hierarchy.  What the code really wanted to do is to see if it
starts with "refs/tags/".

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano 2014-06-23 14:27:36 -07:00
parent 34d5217584
commit 60a5f5fc79
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
builtin/clone.c
View File

@ -695,7 +695,7 @@ static void write_refspec_config(const char* src_ref_prefix,
if (option_mirror || !option_bare) { if (option_mirror || !option_bare) {
if (option_single_branch && !option_mirror) { if (option_single_branch && !option_mirror) {
if (option_branch) { if (option_branch) {
if (strstr(our_head_points_at->name, "refs/tags/")) if (starts_with(our_head_points_at->name, "refs/tags/"))
strbuf_addf(&value, "+%s:%s", our_head_points_at->name, strbuf_addf(&value, "+%s:%s", our_head_points_at->name,
our_head_points_at->name); our_head_points_at->name);
else else