undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

osxkeychain: clarify that we ignore unknown lines

Browse Source 
Like in all the other credential helpers, the osxkeychain helper
ignores unknown credential lines.

Add a comment (a la the other helpers) to make it clear and explicit
that this is the desired behaviour.

Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Matthew John Cheetham 2022-09-22 16:59:34 +00:00 committed by Junio C Hamano
parent 6ea87d97af
commit 630a6429a7
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
contrib/credential/osxkeychain/git-credential-osxkeychain.c
View File

@ -159,6 +159,11 @@ static void read_credential(void)
username = xstrdup(v); username = xstrdup(v);
else if (!strcmp(buf, "password")) else if (!strcmp(buf, "password"))
password = xstrdup(v); password = xstrdup(v);
/*
* Ignore other lines; we don't know what they mean, but
* this future-proofs us when later versions of git do
* learn new lines, and the helpers are updated to match.
*/
} }
} }