undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t5318: use 'test_must_be_empty'

Browse Source 
A handful of tests in t5318 use 'test_line_count = 0 ...' to make sure
that some command does not write any output. While correct, it is more
idiomatic to use 'test_must_be_empty' instead. Switch the former
invocations to use the latter instead.

Signed-off-by: Taylor Blau <me@ttaylorr.com>
Acked-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Taylor Blau 2020-06-03 16:21:07 -06:00 committed by Junio C Hamano
parent b3d7a52fac
commit 6334c5ff97
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
t/t5318-commit-graph.sh
View File

@ -140,7 +140,7 @@ test_expect_success 'Add more commits' '
test_expect_success 'commit-graph write progress off for redirected stderr' ' test_expect_success 'commit-graph write progress off for redirected stderr' '
cd "$TRASH_DIRECTORY/full" && cd "$TRASH_DIRECTORY/full" &&
git commit-graph write 2>err && git commit-graph write 2>err &&
test_line_count = 0 err test_must_be_empty err
' '
test_expect_success 'commit-graph write force progress on for stderr' ' test_expect_success 'commit-graph write force progress on for stderr' '
@ -152,13 +152,13 @@ test_expect_success 'commit-graph write force progress on for stderr' '
test_expect_success 'commit-graph write with the --no-progress option' ' test_expect_success 'commit-graph write with the --no-progress option' '
cd "$TRASH_DIRECTORY/full" && cd "$TRASH_DIRECTORY/full" &&
git commit-graph write --no-progress 2>err && git commit-graph write --no-progress 2>err &&
test_line_count = 0 err test_must_be_empty err
' '
test_expect_success 'commit-graph verify progress off for redirected stderr' ' test_expect_success 'commit-graph verify progress off for redirected stderr' '
cd "$TRASH_DIRECTORY/full" && cd "$TRASH_DIRECTORY/full" &&
git commit-graph verify 2>err && git commit-graph verify 2>err &&
test_line_count = 0 err test_must_be_empty err
' '
test_expect_success 'commit-graph verify force progress on for stderr' ' test_expect_success 'commit-graph verify force progress on for stderr' '
@ -170,7 +170,7 @@ test_expect_success 'commit-graph verify force progress on for stderr' '
test_expect_success 'commit-graph verify with the --no-progress option' ' test_expect_success 'commit-graph verify with the --no-progress option' '
cd "$TRASH_DIRECTORY/full" && cd "$TRASH_DIRECTORY/full" &&
git commit-graph verify --no-progress 2>err && git commit-graph verify --no-progress 2>err &&
test_line_count = 0 err test_must_be_empty err
' '
# Current graph structure: # Current graph structure: